Expose getFileTypeIconAsURL helper for react-file-type-icons #27940
+143
−11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
📊 Bundle size report🤖 This report was generated against c0214bcb7d9369db75eb842adf4253893bc0e160 |
|
cc: @behowell for visibility |
Asset size changesUnable to find bundle size details for Baseline commit: ab90189 Possible causes
Recommendations
|
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit acf0be6:
|
|
@micahgodbolt is this something to help with while Ben is oof? cc: @grace-zou |
tomi-msft
approved these changes
Jun 7, 2023
|
/azp run |
|
Azure Pipelines successfully started running 4 pipeline(s). |
|
I have approved and merged this PR: #27336. Can you pull from master and update this PR? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previous Behavior
File Type Icons can't be used with Fluent 9 unless you import Fluent 8
<Icon />or use React to dangerously set inner HTML.New Behavior
Expose a new helper method so Fluent 9 code can use
<img src={getFileTypeIconAsURL()} />.Related Issue(s)